Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Bug: When the message strips are accessed, the information inside the message strips are not conveyed (screen reader) #3123

Closed
puru-hk opened this issue Aug 28, 2020 · 11 comments
Assignees
Labels
ATL Accessibility Test Labs core Core library specific issues documentation There is an issue with documentation Medium During the normal course of the development activities defect should be resolved. planned the issues that are planned to be handled during a sprint question Further information is requested rework required Validation failed

Comments

@puru-hk
Copy link
Contributor

puru-hk commented Aug 28, 2020

Fundamental core component: "Message Strip"

Description: When the message strips are accessed, the information inside the message strips are not conveyed (screen reader)

Expected: The content inside the message strips should be conveyed properly when the message strips are accessed(screen reader)

Attached the screenshot

image

Note: - Issue persists for all the message strips present within the ‘Message strip’ control.

@puru-hk puru-hk added core Core library specific issues Medium During the normal course of the development activities defect should be resolved. labels Sep 23, 2020
@puru-hk puru-hk added accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support Screen Reader labels Oct 1, 2020
@puru-hk puru-hk added the bug Something isn't working label Nov 10, 2020
@puru-hk puru-hk added ATL Accessibility Test Labs and removed accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support labels Mar 3, 2021
@kavya-b kavya-b self-assigned this May 24, 2021
@kavya-b kavya-b added this to the Sprint 63 - Ariba milestone May 24, 2021
@puru-hk
Copy link
Contributor Author

puru-hk commented Jun 1, 2021

@Sanjay-1312 Please test this issue in this url https://deploy-preview-5458--fundamental-ngx.netlify.app

@Sanjay-1312
Copy link

Hello Colleagues,

The issue is not fixed, hence i am re opening the issue.
On accessing the 'Message Strip', the close information is only read, the message strip information is not read.
There is no keyboard support for the message strip where there is Close button is not available.

URL: https://deploy-preview-5458--fundamental-ngx.netlify.app
JAWS 2021

Screenshot :
image

@puru-hk puru-hk added the rework required Validation failed label Jun 2, 2021
@puru-hk
Copy link
Contributor Author

puru-hk commented Jun 2, 2021

@kavya-b This issue is not fixed it-seems. Kindly have a look.

@kavya-b
Copy link
Contributor

kavya-b commented Jun 2, 2021

As discussed with @puru-hk and @Sanjay-1312, the only way we see to fix this in JAWS is to provide tabindex="0" on the message strip. This means adding focus on message strip, which is not specified in the Fiori3 visual specs. Without this, even the UI5 example for message strip does not read the strip if a close button is not present.
Another issue is that UI5 reads the entire message strip content on tabbing to the close button. Is this correct behaviour? Shouldn't a button read only what it is trying to indicate rather than the entire strip's contents? Also the message strip should read what it is trying to indicate. I think this is a question for designers as well. cc: @manjunathanagaraj @kenykim

@Sanjay-1312 will follow up with his team to understand whether we need focus on the entire message strip and how can they test a strip without a close button, if it is expected that close button will read out the entire strip's information.

@kavya-b
Copy link
Contributor

kavya-b commented Jun 2, 2021

@InnaAtanasova @droshev currently, we do not have focus specification by Fiori for Message Strip. However, it seems like this is necessary in order for screen readers(especially JAWS) to read the message strip content.

Can you let us know if we can get the focus specs added to Message Strip visual specs or if we can use the general Focus Visual Concept spec to apply focus to Message Strip in order to address this a11y issue? It would also help if we get feedback from design team regarding this. Please help.

This PR and issue is blocked until we are able to add focus to Message Strip container.
cc: @manjunathanagaraj

@manjunathanagaraj manjunathanagaraj removed this from the Sprint 63 - Ariba milestone Jun 8, 2021
@droshev
Copy link
Contributor

droshev commented Jun 12, 2021

@kavya-b the content in the message strip is custom and it is up to application developers to create. If the use case is to have focusable elements then the reader app will focus and read. We don't control what it is inside.

@droshev droshev closed this as completed Jun 12, 2021
@droshev droshev added documentation There is an issue with documentation question Further information is requested and removed bug Something isn't working core Core library specific issues labels Jun 12, 2021
@kavya-b
Copy link
Contributor

kavya-b commented Jun 17, 2021

@droshev I agree we don't have control on the content, but the a11y team's requirements say the following:

  • when a close button is present for the strip, tabbing to the button should read the entire strip content, the status of the strip and the button information.
  • when a close button is not present for the strip, they verify only the static elements(message strip text etc) separately through a different mode of JAWS navigation

this way, focus on the whole message strip is no longer required, but extra information would have to be read out from the close button.

request @Sanjay-1312 to add your thoughts and suggest if @droshev 's comment is okay then we can keep this issue closed, or reopen this issue as needed.

cc: @puru-hk @manjunathanagaraj

@puru-hk
Copy link
Contributor Author

puru-hk commented Oct 22, 2021

This issue is not fixed. Hence reopening this issue.

@puru-hk puru-hk reopened this Oct 22, 2021
@nickiovenko nickiovenko added this to the Sprint 76 - Ariba milestone Dec 1, 2021
@Betrozov Betrozov removed Screen Reader rework required Validation failed labels Dec 1, 2021
@Betrozov Betrozov self-assigned this Dec 6, 2021
@Betrozov Betrozov added the planned the issues that are planned to be handled during a sprint label Dec 6, 2021
@Veerakarthick
Copy link

Hello Colleague ,

Retest has been taken reported issue still persist the same.
Description: When the message strips are accessed, the information inside the message strips are not conveyed (screen reader)

Expected: The content inside the message strips should be conveyed properly when the message strips are accessed(screen reader)
Screenshot:
image

REgards,
Karthikeyan.c

@manjunathanagaraj manjunathanagaraj added the core Core library specific issues label Feb 9, 2022
@Veerakarthick
Copy link

Veerakarthick commented Mar 22, 2022

Hello Colleague,

Retest has been taken reported issue still persist the same so please check and do the needful.
Description: When the message strips are accessed, the information inside the message strips are not conveyed (screen reader)

Expected: The content inside the message strips should be conveyed properly when the message strips are accessed(screen reader)

Screenshot:
image

Retest environment:
URL: https://deploy-preview-5458--fundamental-ngx.netlify.app/
JAWS 2021

Regards,
Karthikeyan.c

@Karthickc1994
Copy link

Hello Colleague,

Retest has been taken with the below environment test results are below:

Issue: When the message strip is accessed the information within the message strip is not read out.
Reading made as:
Close Button
To activate press spacebar.
Close Button
To activate press spacebar.
Close Button
To activate press spacebar.
 Show Code Button
To activate press spacebar.

Screen shot:
image

Expected behavior:
when the message strip is accessed the information within the message strip should read out by the screen reader.

Retest Environment:
URL:https://deploy-preview-5458--fundamental-ngx.netlify.app
Browser: Version 101.0.4951.54 (Official Build) (64-bit)
Screen Reader: JAWS 2022.2204.20 ILM

Regards,
Karthikeyan.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ATL Accessibility Test Labs core Core library specific issues documentation There is an issue with documentation Medium During the normal course of the development activities defect should be resolved. planned the issues that are planned to be handled during a sprint question Further information is requested rework required Validation failed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants