Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sap.m.Dialog (1.52.4): no stretch to full screen on desktop #1876

Closed
HannesLadstaetter opened this issue Feb 7, 2018 · 2 comments
Closed

sap.m.Dialog (1.52.4): no stretch to full screen on desktop #1876

HannesLadstaetter opened this issue Feb 7, 2018 · 2 comments
Assignees
@stephania87
Labels
consulting documentation in progress

Comments

@HannesLadstaetter
Copy link

OpenUI5 version:
1.52.4

Browser/version (+device/version):
Chrome 64 / Windows 10

Steps to reproduce the problem:

  1. Enter Url https://openui5.hana.ondemand.com/1.52.4/?sap-ui-language=EN#/sample/sap.m.sample.Dialog/preview

  2. Open Developer Tools (F12) and set a breakpoint in line 51 of file C.controller.js

image

  1. Press Dialog

image

  1. Enter this.pressDialog.setStretch(true) in Console when breakpoint is reached

image

  1. Continue => dialog is not stretched to full screen

image

  1. Do the same with https://openui5.hana.ondemand.com/1.50.8/?sap-ui-language=EN#/sample/sap.m.sample.Dialog/preview and compare the results

What is the expected result?

Dialog is stretched to full screen like in 1.50.8 and previous versions

image

What happens instead?

Dialog is not stretched to full screen

image
@stephania87
Copy link

@HannesLadstaetter Thanks for reporting the issue. My colleagues will check the case with ticket #1880142654, and they will post an update here.

For anyone interested in the settings reproducing the problem, please check https://jsbin.com/pugosabovo/edit?html,output

@stephania87 stephania87 self-assigned this Feb 7, 2018
@GerganaKremenska
Copy link
Member

Hello @HannesLadstaetter,

This is the new behavior wanted by design.
When you have stretch property to true in sap.m.Dialog on Desktop it will take 93% of the viewport.
When you have stretch property to true in sap.m.Dialog on Mobile it will take 100% of the viewport.
I have update the documentation.

Best Regards,
Gergana

@boghyon boghyon mentioned this issue Feb 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephania87 stephania87

Labels
consulting documentation in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephania87 @GerganaKremenska @HannesLadstaetter