Replies: 1 comment 2 replies
-
|
It's not going to be removed anytime soon, don't worry. But it is recommended to use the new HTML |
Beta Was this translation helpful? Give feedback.
-
|
@saadeghi ok, thank you. But what's the best way to use the new HTML const dialogRef = useRef<HTMLDialogElement>(null)
useEffect(() => {
if (dialogRef.current?.open && !showModal.show) {
dialogRef.current?.close()
} else if (!dialogRef.current?.open && showModal.show) {
dialogRef.current?.showModal()
}
}, [showModal.show])
// ...
return (
<dialog ref={dialogRef}>
...
</dialog>
)Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
I don't use React anymore so I don't know if it's currently the best way or not. This might be helpful: |
Beta Was this translation helpful? Give feedback.
-
Is the hidden checkbox control for the modal control going away?
Correct me if anything I say is wrong...
But the new modal controls via javascript and the ID of the modal are very difficult to use and maintain. The ID of my modal isn't tracked via my LSP, so eslint is yelling at me that my modal ID doesn't exist.
The "legacy" checkbox system allowed me to store and track a boolean with my LSP, and then pass that variable to the checkbox. So it was easy for me to track the open/close state of my modal & control it with a single variable. With the new imperative JavaScript method, I lose that ability and must remember to run side effects every time I open a modal.
I'd really like if something like the "legacy" system was still maintained...
Beta Was this translation helpful? Give feedback.
All reactions