Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionalize units argument. #22

Open
samussiah opened this issue Jan 31, 2017 · 2 comments
Open

Optionalize units argument. #22

samussiah opened this issue Jan 31, 2017 · 2 comments
Projects
Milestone

Comments

@samussiah
Copy link
Contributor

samussiah commented Jan 31, 2017

Measure dropdown options should include units.

@jwildfire jwildfire added this to the v2.1.0 milestone Feb 14, 2017
@jwildfire
Copy link
Contributor

Can you provide a bit more detail in the description? What happens in 2.0.0 if units aren't provided?

@samussiah
Copy link
Contributor Author

samussiah commented Feb 15, 2017

The issue here is ADaM data where units are not necessarily standardized and measures may have more than one associated unit. In ADaM the units are concatenated to the measure in a single variable named PARAM.

In order to distinguish records within a measure with differing units MEASURE_COL needs to include units. ADaM already does this. We could take the renderer two directions:

  1. Make UNITS_COL optional and assume values of MEASURE_COL are unique for each unit, as is currently implemented in safety-histogram.
  2. Concatenate MEASURE_COL and UNITS_COL within the renderer.

@emmorris emmorris modified the milestones: v2.1.0, v2.2.0 Nov 20, 2017
@samussiah samussiah added this to To do in v2.2.0 via automation Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2.2.0
  
To do
Development

No branches or pull requests

3 participants